-
-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple worker executors #4869
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
76cc762
Task annotations passed down to workers
madsbk 758fa9e
Clean up worker's executors
madsbk 8bc91de
Make tests inspect w.executors["default"]
madsbk a4e3e58
Implementing the "executor" annotation
madsbk 7800a70
Handle when ts.annotations is None
madsbk 6faa483
Added Worker.executor for backwards compatibility
madsbk de07415
Added a test
madsbk aa1a71b
Revert "Make tests inspect w.executors["default"]"
madsbk 1e40b3d
Docs
madsbk d0f3841
Merge branch 'main' of github.com:dask/distributed into multiple_exec…
madsbk 802a4c8
Use executor_wait even when not ThreadPoolExecutors
madsbk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious why we're doing this step manually (I realize this predates this PR -- this isn't meant to be a blocker for merging the changes here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is because even with
shutdown(wait=False)
, theThreadPoolExecutor
will still run pending tasks. By callingexecutor._work_queue.queue.clear()
, we cancel them before shutting down.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see. Thanks for clarifying! FWIW it looks like a
cancel_futures=
keyword was added toExecutor.shutdown
in Python 3.9. Just pointing this out as something we can use in the future once 3.9 is our minimum Python version