-
-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the new HLG pack/unpack API in Dask #4489
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
349e26e
to
2550bee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work here @madsbk! I pushed an update to run CI against dask/dask#7179 to ensure that the distributed test suite passes too.
We'll also want to update the minimum supported version of dask
to make sure HighLevelGraph
s have the new __dask_distributed_(un)pack__
API. Historically what we've done in this case is update distributed
s requirements.txt
to point to the master
branch of dask
and add a TODO
comment to update to the latest dask
release prior to releasing distributed
d5718f9
to
b6bb295
Compare
Thanks @jrbourbeau, both PRs should work now. I have added some tests of the issue in Dask and renamed Some of the CI runs fails in |
Yeah you're correct, that failure is be related to pointing CI to your branch. Since our versioning system,
This is okay as it's only an artifact of pointing to a fork of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @madsbk! This LGTM. See my comment at dask/dask#7179 (review) about waiting a day to merge this PR
This PR makes Distributed use the new high level graph pack/unpack API in Dask: dask/dask#7179
black distributed
/flake8 distributed