Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate support for legacy @gen_cluster functions #3738

Merged
merged 5 commits into from
Apr 24, 2020

Conversation

crusaderky
Copy link
Collaborator

Revert change in #3706 that caused non-async functions decorated by @gen_cluster and @gen_test to break.

Clean up some more Python<3.6-specific code.

@mrocklin
Copy link
Member

This looks great to me. Thank you for handling this quickly @crusaderky .

@jrbourbeau any objection to a micro-release after this gets merged? This will fix some downstream package test failures.

@crusaderky crusaderky closed this Apr 24, 2020
@crusaderky crusaderky reopened this Apr 24, 2020
@jrbourbeau
Copy link
Member

Yeah for sure, I'm planning to do the 2.15.0 release tomorrow anyways

@mrocklin mrocklin merged commit ecdcb33 into dask:master Apr 24, 2020
@mrocklin
Copy link
Member

Thanks @crusaderky ! This is in.

@crusaderky crusaderky deleted the legacy_gen_cluster branch April 24, 2020 09:19
@chinmaychandak
Copy link

Thanks a lot for taking care of this so quickly, @crusaderky!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants