Fix flaky test_oversubscribing_leases #3726
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should finally fix #3717 by introducing two changes
refresh_leases
variable now instead of start-/stopping it. Also, I explicitly verify that the internals do what they are supposed to do by capturing the logs. Has anybody else encountered a PC behaviour like this before? Is start/stop/start something we are not supposed to do with PCs?I couldn't reproduce the race condition in the first point but I am now more confident that the test is doing what it was intended to do when running it locally and I don't see any more room for race conditions atm.
Sorry for the flaky test, I hope this fixes the issue now
cc @mrocklin