Skip to content

Commit

Permalink
Use contextmanager to ensure clients are closed and do not leak (#6817)
Browse files Browse the repository at this point in the history
  • Loading branch information
hendrikmakait authored Aug 1, 2022
1 parent 94fe41e commit af14937
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions distributed/deploy/tests/test_local.py
Original file line number Diff line number Diff line change
Expand Up @@ -1269,12 +1269,13 @@ def test_localcluster_start_exception(loop):
pass


def test_localcluster_get_client():
def test_localcluster_get_client(loop):
with LocalCluster(
n_workers=0, asynchronous=False, dashboard_address=":0"
n_workers=0, asynchronous=False, dashboard_address=":0", loop=loop
) as cluster:
client1 = cluster.get_client()
assert client1.cluster == cluster
client2 = Client(cluster)
assert client1 != client2
assert client2 == cluster.get_client()
with cluster.get_client() as client1:
assert client1.cluster == cluster

with Client(cluster) as client2:
assert client1 != client2
assert client2 == cluster.get_client()

0 comments on commit af14937

Please sign in to comment.