Issue 478 fix -- Documentation link error #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 13, 2019 12:17
jrbourbeau
reviewed
Mar 13, 2019
dask_ml/wrappers.py
Outdated
| @@ -386,7 +386,7 @@ class Incremental(ParallelPostFit): | |||
| used during the call to ``fit``. All attributes learned during training | |||
| are available on ``Incremental`` directly. | |||
|
|
|||
| .. _list of incremental learners: http://scikit-learn.org/stable/modules/scaling_strategies.html#incremental-learning # noqa | |||
| .. _list of incremental learners: https://scikit-learn.org/0.15/modules/scaling_strategies.html#incremental-learning # noqa | |||
There was a problem hiding this comment.
I think this page was moved to https://scikit-learn.org/stable/modules/computing.html#incremental-learning
There was a problem hiding this comment.
@jrbourbeau are the changes okay ? or do I need to update the link that you mentioned!
There was a problem hiding this comment.
Preferably update to @jrbourbeau's link, so that as changes are made they're reflected in what we link to.
There was a problem hiding this comment.
Sure @TomAugspurger . I will modify it and commit the changes
|
Just to be clear, you can push another commit to this branch. No need for a
new PR.
…On Wed, Mar 13, 2019 at 5:22 PM Sriharsha Atyam ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In dask_ml/wrappers.py
<#483 (comment)>:
> @@ -386,7 +386,7 @@ class Incremental(ParallelPostFit):
used during the call to ``fit``. All attributes learned during training
are available on ``Incremental`` directly.
- .. _list of incremental learners: http://scikit-learn.org/stable/modules/scaling_strategies.html#incremental-learning # noqa
+ .. _list of incremental learners: https://scikit-learn.org/0.15/modules/scaling_strategies.html#incremental-learning # noqa
Sure @TomAugspurger <https://github.com/TomAugspurger> . I will modify it
and send a PR
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#483 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABQHIk49DKKiJ7vECsyR8l60SzEiy-X0ks5vWXoLgaJpZM4bv-oh>
.
|
This was referenced Mar 15, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the https://ml.dask.org/modules/generated/dask_ml.wrappers.Incremental.html#dask_ml.wrappers.Incremental there is a link which redirects to scikit learn scaling strategies page when you click the list of incremental learners and it is not working anymore and I updated the new link.