New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor glm updates #422

Merged

TomAugspurger merged 1 commit into dask:master from jrbourbeau:logistic_reg_cleanup

Oct 30, 2018

Member

jrbourbeau commented Oct 29, 2018

This PR makes a few of minor changes to the _GLM base estimator. Namely:

Adds max_iter parameter to the docstring
Renames the multiclass keyword to multi_class to match the corresponding scikit-learn keyword (ref: scikit-learn's LogisticRegression). Even though this keyword is currently ignored in dask-ml, I still think it's worth being consistent with scikit-learn.
Moves the position of the max_iter keyword the _GLM.__init__ signature to have the same order as scikit-learn.


          Minor LogisticRegression updates

77ebb2e

TomAugspurger merged commit ce6b337 into dask:master

Member

TomAugspurger commented Oct 30, 2018

Thanks!

TomAugspurger mentioned this pull request

Fix the link in dask documentation #479

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet