Bump sklearn min version to 0.20 #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit b6e182b)
TomAugspurger
commented
Oct 8, 2018
| @@ -65,8 +65,7 @@ | |||
| __all__ = ["GridSearchCV", "RandomizedSearchCV"] | |||
|
|
|||
|
|
|||
| if SK_VERSION >= packaging.version.parse("0.19.1"): | |||
| from sklearn.utils.deprecation import DeprecationDict | |||
| if SK_VERSION <= packaging.version.parse("0.21.dev0"): | |||
There was a problem hiding this comment.
FYI @jrbourbeau aaa0b31 has your commit bringing in DeprecationDict, and I updated the logic here. I think the correct behavior is
- Include the train-score keys and warn for 0.20.x
- Do not include the train-score keys for >=0.21.dev0
There was a problem hiding this comment.
LGTM, I agree with the logic here
|
Py36 and sklearn_dev passed earlier. The py27 build stalled so I restarted it. https://circleci.com/gh/dask/dask-ml/2508?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link |
|
That passed. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #391
Closes #383
Closes #384
Subsumes #389