-
-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CI issues #382
Fix CI issues #382
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this.
May need to remove the
filterwarnings =
error:::sklearn[.*]
from our setup.cfg, at least temporarily.
@@ -29,6 +29,7 @@ dependencies: | |||
- sphinx_rtd_theme | |||
- sphinx-gallery | |||
- tensorflow | |||
- testpath<0.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What prompted this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I came across https://stackoverflow.com/questions/52582563/pip-install-attributeerror-distinfodistribution-dep-map and conda-forge/testpath-feedstock#7 after a little bit of Google-ing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely just a quick fix until a new release is out, but it seems to be working for the moment
Well, the 36 build is passing, thanks. For the 2.7 build, I would see if removing that I'd ignore the sklearn dev failures for now. I'll go through them when I have time. I suspect that the 0.20 release opened up some floodgates :) |
The sklearn dev failure is due to |
Works for me! I've gotta step away to run some errands. I can work on the sklearn dev failure later on, but I'm okay with merging this PR in (if you approve of the changes of course :) ) |
Thanks for working on this. |
This PR is to try and fix
pip
-related CI build issuesRef #381