Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI issues #382

Merged
merged 5 commits into from
Oct 4, 2018
Merged

Fix CI issues #382

merged 5 commits into from
Oct 4, 2018

Conversation

jrbourbeau
Copy link
Member

This PR is to try and fix pip-related CI build issues

Ref #381

@jrbourbeau jrbourbeau changed the title Fix pip install CI failure Fix CI issues Oct 4, 2018
Copy link
Member

@TomAugspurger TomAugspurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this.

May need to remove the

filterwarnings =
    error:::sklearn[.*]

from our setup.cfg, at least temporarily.

@@ -29,6 +29,7 @@ dependencies:
- sphinx_rtd_theme
- sphinx-gallery
- tensorflow
- testpath<0.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What prompted this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

@jrbourbeau jrbourbeau Oct 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely just a quick fix until a new release is out, but it seems to be working for the moment

@TomAugspurger
Copy link
Member

Well, the 36 build is passing, thanks. For the 2.7 build, I would see if removing that filterwarnings fixes things.

I'd ignore the sklearn dev failures for now. I'll go through them when I have time. I suspect that the 0.20 release opened up some floodgates :)

@jrbourbeau
Copy link
Member Author

The sklearn dev failure is due to DeprecationDict being removed in scikit-learn/scikit-learn#12241

@jrbourbeau
Copy link
Member Author

I'd ignore the sklearn dev failures for now. I'll go through them when I have time.

Works for me! I've gotta step away to run some errands. I can work on the sklearn dev failure later on, but I'm okay with merging this PR in (if you approve of the changes of course :) )

@TomAugspurger
Copy link
Member

Thanks for working on this.

@TomAugspurger TomAugspurger merged commit 61e8786 into dask:master Oct 4, 2018
@jrbourbeau jrbourbeau deleted the fix_CI branch October 5, 2018 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants