Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple issues when given a small grid.
For the first, we decided that training 0 models was best, as
inverse(next_time_step)
was 0.For the second, we got stuck in an infinite
while True
loop sinceinverse(current_time_step) == inverse(next_time_step)
was always equal (both were 0), andWe could detect this and raise when something like
start < current_time_step + 1
, but ideally we would support this. I'm not sure that my fix is correct though.