Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update traefik's CRDs #554

Merged
merged 2 commits into from
Apr 21, 2022
Merged

Conversation

consideRatio
Copy link
Collaborator

@consideRatio consideRatio commented Apr 21, 2022

To update Traefik's CRDs is a breaking change that requires manual intervention from users with an existing installation of the dask-gateway helm chart, due to that, I want to update them to the latest version before release.

@dhirschfeld
Copy link

I'll just mention, in case you haven't already seen, the CRDs can be updated with e.g.

kubectl apply --server-side --force-conflicts -k https://github.com/traefik/traefik-helm-chart/tree/v19.0.4/traefik/crds

xref: traefik/traefik-helm-chart#649

Copying locally might still be easier for your users though.

@consideRatio
Copy link
Collaborator Author

Thanks @dhirschfeld!

@consideRatio
Copy link
Collaborator Author

consideRatio commented Nov 9, 2022

@dhirschfeld do you grasp if --server-side --force-conflicts makes sense to suggest overall when doing kubectl apply of the bundled CRDs?

      --server-side=false: If true, apply runs in the server instead of the client.
      --force-conflicts=false: If true, server-side apply will force the changes against conflicts.

@dhirschfeld
Copy link

TBH, I'm no expert here and I don't really have a good grasp on the differences between a server-side and a normal apply.

My understanding of --force-conflicts is that it will allow making changes to existing fields which we'd definitely want to do here. I'm not too sure when you'd want an apply to not make changes - maybe if an apply was supposed to only add new fields and not update any existing ones having the update error might be useful.

This doc has a pretty good/understandable explanation:

...and doing some more research brought up this blog which has a bit more context:

It sounds like it's supposed to be a new, better (show diffs, detect conflicts, ???) way to do a kubectl apply

@consideRatio
Copy link
Collaborator Author

Thanks for helping out with the learning process, I'm leaning towards thinking we should suggest both --server-side and --force-conflicts

@dhirschfeld
Copy link

I'm leaning towards thinking we should suggest both --server-side and --force-conflicts

I think that's the way to go also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants