Remove versions from matchLabels in helm chart #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite helm's recommendations, versions should *not* be included in `matchLabels` in deployments, as they're immutable once created. Including versions or other frequently changing things in `matchLabels` means that `helm upgrade` will fail if the chart/app version increments, as the `matchLabels` cannot be updated. [ci skip]
|
See helm/charts#7680 for reference. |
This was referenced Dec 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite helm's recommendations, versions should not be included in
matchLabelsin deployments, as they're immutable once created.Including versions or other frequently changing things in
matchLabelsmeans that
helm upgradewill fail if the chart/app version increments,as the
matchLabelscannot be updated.Fixes #147.