Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: release dashmate packages #669

Merged
merged 6 commits into from
Dec 16, 2022
Merged

ci: release dashmate packages #669

merged 6 commits into from
Dec 16, 2022

Conversation

strophy
Copy link
Collaborator

@strophy strophy commented Dec 14, 2022 •
edited
Loading

Issue being fixed or feature implemented

We need to build dashmate binaries, but oclif is stuck on yarn 1.

What was done?

  • Make oclif work with yarn 3 using patches
  • Add dashmate build CI

How Has This Been Tested?

On strophy/platform

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov changed the title ci: dashmate packages ci: release dashmate packages Dec 14, 2022
shumkov
shumkov reviewed Dec 14, 2022
View reviewed changes
shumkov
shumkov approved these changes Dec 16, 2022
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@strophy strophy merged commit 0cd0382 into master Dec 16, 2022
@strophy strophy deleted the ci/oclif-pack branch December 16, 2022 23:48
@thephez thephez added this to the v0.23.x milestone Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@antouhou antouhou Awaiting requested review from antouhou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.23.x
Development

Successfully merging this pull request may close these issues.
3 participants
@strophy @shumkov @thephez