Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dashmate): provide debug information if version check fails #1936

Merged
merged 2 commits into from
Jul 9, 2024

Conversation

shumkov
Copy link
Member

@shumkov shumkov commented Jul 9, 2024

Issue being fixed or feature implemented

Sometimes dashmate fails with:

Invalid version. Must be a string. Got type "object".

What was done?

  • Added debug output in case if docker version check fails

How Has This Been Tested?

None

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@shumkov shumkov requested a review from QuantumExplorer as a code owner July 9, 2024 10:13
@shumkov shumkov added this to the v1.1 milestone Jul 9, 2024
@shumkov shumkov requested a review from pshenmic July 9, 2024 10:14
pshenmic
pshenmic previously approved these changes Jul 9, 2024
@shumkov shumkov modified the milestones: v1.1, v1.0.0 Jul 9, 2024
@shumkov shumkov merged commit 11a7bc7 into v1.0-dev Jul 9, 2024
125 checks passed
@shumkov shumkov deleted the chore/dashmate/imporve-version-help branch July 9, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants