Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(drive-abci): added some comments on the initial core height and quorums #1849

Merged
merged 2 commits into from
May 21, 2024

Conversation

QuantumExplorer
Copy link
Member

Issue being fixed or feature implemented

What was done?

Just added a few comments explaining the initial core chain locked height and how quorums are selected based on it.

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@QuantumExplorer QuantumExplorer requested a review from shumkov as a code owner May 20, 2024 13:25
@QuantumExplorer QuantumExplorer changed the title doc: added some comments on the initial core height and quorums docs(drive-abci): added some comments on the initial core height and quorums May 20, 2024
lklimek
lklimek previously approved these changes May 20, 2024
@QuantumExplorer QuantumExplorer merged commit 3e163aa into v1.0-dev May 21, 2024
16 checks passed
@QuantumExplorer QuantumExplorer deleted the doc/addSomeComments branch May 21, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants