refactor(platform)!: document creation/update/deletion does not refetch contract #1840
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Document creation, update and deletion all told drive about the contract by setting the contract id. Drive would then refetch the contract from disk.
Even though most of the time it would fetch it from cache, this still was not ideal, because the processing cost of a fetch from cache is the same as a fetch from disk.
What was done?
A new type was created that encapsulates all types on data contract info, and we made the document operations in drive more straightforward hiding away most of the complexity. Now there are just a single operation allowed for adding, updating, or deleting.
How Has This Been Tested?
Tests continue to pass.
Breaking Changes
Since we no longer fetch the contract in drive, drive will report less processing costs, this means that this is a breaking change.
Checklist:
For repository code-owners and collaborators only