Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: enforce warnings as errors #1783

Merged
merged 4 commits into from
Mar 16, 2024
Merged

Conversation

PastaPastaPasta
Copy link
Member

@PastaPastaPasta PastaPastaPasta commented Mar 16, 2024

Issue being fixed or feature implemented

Enforce warnings as errors in CI

What was done?

Enforce warnings as errors; and fix a few more warnings

How Has This Been Tested?

Running cargo check --tests locally in root; and cargo hack check

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@QuantumExplorer QuantumExplorer merged commit 6a62ae3 into v1.0-dev Mar 16, 2024
113 checks passed
@QuantumExplorer QuantumExplorer deleted the ci/enforce-warnings-as-errors branch March 16, 2024 19:25
@QuantumExplorer
Copy link
Member

Nice one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants