feat(platform)!: created at updated at from block time #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumkov
requested changes
Mar 15, 2024
...document/documents_batch_transition/document_transition/document_create_transition/v0/mod.rs
Outdated
Show resolved
Hide resolved
...document/documents_batch_transition/document_transition/document_create_transition/v0/mod.rs
Outdated
Show resolved
Hide resolved
...ocument/documents_batch_transition/document_transition/document_replace_transition/v0/mod.rs
Outdated
Show resolved
Hide resolved
...ocument/documents_batch_transition/document_transition/document_replace_transition/v0/mod.rs
Outdated
Show resolved
Hide resolved
|
@QuantumExplorer feel free to merge it when you resolve my comments. |
shumkov
previously approved these changes
Mar 15, 2024
There was a problem hiding this comment.
@QuantumExplorer My approval in advance if you gonna be a good boy.
QuantumExplorer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Previously before this PR, users submitting documents were expected to set the document created at and updated at time on the client side. Then Platform would validate in consensus that these values were close to to the current block time. This approach had a few downsides. First it meant that documents in mempool would expire even though users did nothing wrong. The second is that it required users to have a clock that was very close in time to the network time.
What was done?
Now created at and updated at are set by the block time. Meaning that they are automatic and users have nothing to set manually.
How Has This Been Tested?
Test suite is passing
Breaking Changes
This is a breaking change.
Checklist:
For repository code-owners and collaborators only