feat(platform)!: key disabled at based on state transition block time #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dashpay/platform into feat/betterDataContractUpdateProcessing
…dashpay/platform into feat/betterDataContractUpdateProcessing
QuantumExplorer
deleted the
feat/keyDisabledAtBasedOnStateTransitionBlockTime
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Disabled at was part of identity update state transition. However it was user based, which could cause issues if transactions were in mempool for too long.
What was done?
Instead of being user based, the disabled at is now based on block execution, it will take the block execution time instead.
How Has This Been Tested?
Our test suite.
Breaking Changes
Removed disabled at from state transition. Removed validation logic for disabled at.
Checklist:
For repository code-owners and collaborators only