Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: strategy test start identities #1749

Merged
merged 3 commits into from
Mar 9, 2024

Conversation

pauldelucia
Copy link
Member

@pauldelucia pauldelucia commented Mar 7, 2024

Issue being fixed or feature implemented

Strategy test start identities needed to be reset every strategy run before since the field was a vector of state transitions, and once the transition was added to the chain, it obviously couldn't be added again in a subsequent run. Changing it to a number which specifies how many start identities to create on the first block solves this issue.

What was done?

Change start_identities field in Strategy to a tuple of u8s, the first one specifying the number of identities to create and the second one the number of keys per identity. I did disable one test in rs-drive-abci strategy tests because it either doesn't work under this new design, or it will have to be heavily refactored. There is also a corresponding PR in rs-platform-explorer dashpay/platform-tui#27

How Has This Been Tested?

Strategy tests in Platform TUI and cargo test

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

QuantumExplorer
QuantumExplorer previously approved these changes Mar 8, 2024
@QuantumExplorer QuantumExplorer merged commit 1ca71e3 into v1.0-dev Mar 9, 2024
23 checks passed
@QuantumExplorer QuantumExplorer deleted the refactor-strategy-start-identities branch March 9, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants