refactor: strategy test start identities #1749
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Strategy test start identities needed to be reset every strategy run before since the field was a vector of state transitions, and once the transition was added to the chain, it obviously couldn't be added again in a subsequent run. Changing it to a number which specifies how many start identities to create on the first block solves this issue.
What was done?
Change
start_identities
field inStrategy
to a tuple of u8s, the first one specifying the number of identities to create and the second one the number of keys per identity. I did disable one test in rs-drive-abci strategy tests because it either doesn't work under this new design, or it will have to be heavily refactored. There is also a corresponding PR in rs-platform-explorer dashpay/platform-tui#27How Has This Been Tested?
Strategy tests in Platform TUI and cargo test
Breaking Changes
Checklist:
For repository code-owners and collaborators only