Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(drive): internal error on querying specific identity keys #1728

Merged
merged 5 commits into from
Mar 8, 2024

Conversation

markin-io
Copy link
Contributor

@markin-io markin-io commented Mar 1, 2024

Issue being fixed or feature implemented

Fixed "storage: grovedb: not supported: offset must not be set in query_raw_keys_optional" drive error when querying specific keys via identity/keys

What was done?

Provide offset: None in grove db query

How Has This Been Tested?

Tested locally by querying specific identity keys

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have added "!" to the title and described breaking changes in the corresponding section if my code contains any
  • I have made corresponding changes to the documentation if needed

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@markin-io markin-io added this to the v1.0.0 milestone Mar 1, 2024
@shumkov shumkov changed the title fix(drive): internal error on querying specific identity keys fix: internal error on querying specific identity keys Mar 5, 2024
@shumkov shumkov changed the title fix: internal error on querying specific identity keys fix(drive): internal error on querying specific identity keys Mar 5, 2024
Copy link
Member

@QuantumExplorer QuantumExplorer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have preferred that we error when we ask for specific keys with an offset, however this solution (discard the offset) is acceptable to me.

@QuantumExplorer QuantumExplorer merged commit b1d3a52 into v1.0-dev Mar 8, 2024
63 checks passed
@QuantumExplorer QuantumExplorer deleted the fix/drive/identity-keys-specific-keys branch March 8, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants