refactor: returns root-hash if an identity is not found #1251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shotonoff
requested review from
shumkov,
antouhou and
QuantumExplorer
as code owners
lklimek
reviewed
Jul 25, 2023
lklimek
approved these changes
Jul 25, 2023
QuantumExplorer
approved these changes
Jul 25, 2023
shotonoff
deleted the
fix/need-to-provide-proof-fo-non-existence-get-identity
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
The operation verifying an identity-id must not return an error if the identity doesn't exist
What was done?
Added handling edge case when no proof for an identity is found
How Has This Been Tested?
Unit-Test
Breaking Changes
N/A
Checklist:
For repository code-owners and collaborators only