Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dapi): rust client #1238

Merged
merged 34 commits into from
Aug 29, 2023
Merged

feat(dapi): rust client #1238

merged 34 commits into from
Aug 29, 2023

Conversation

fominok
Copy link
Contributor

@fominok fominok commented Jul 20, 2023

Issue being fixed or feature implemented

  1. Create stubs for Rust DAPI client and implement platform's part of requests set.
  2. Minimize CBOR usage for GetDocuments query in Drive.

What was done?

How Has This Been Tested?

It wasn't

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@fominok fominok changed the title feat: RS DAPI client feat: rs DAPI client Jul 20, 2023
@shumkov shumkov changed the title feat: rs DAPI client feat(dapi): rs DAPI client Jul 20, 2023
@shumkov shumkov changed the title feat(dapi): rs DAPI client feat(dapi): Rust DAPI client Jul 20, 2023
shumkov
shumkov requested changes Jul 20, 2023
View reviewed changes
packages/rs-dapi-client/src/address_list.rs Outdated Show resolved Hide resolved
packages/rs-dapi-client/src/core/get_status.rs Outdated Show resolved Hide resolved
packages/rs-dapi-client/src/lib.rs Outdated Show resolved Hide resolved
packages/rs-dapi-client/src/lib.rs Outdated Show resolved Hide resolved
packages/rs-dapi-client/src/lib.rs Outdated Show resolved Hide resolved
packages/rs-dapi-client/src/platform/get_documents.rs Outdated Show resolved Hide resolved
packages/rs-dapi-client/src/platform/get_documents.rs Outdated Show resolved Hide resolved
packages/rs-dapi-client/src/platform/get_documents.rs Outdated Show resolved Hide resolved
packages/rs-dapi-client/src/platform/get_data_contract_history.rs Outdated Show resolved Hide resolved
packages/rs-dapi-client/src/platform/get_data_contract_history.rs Outdated Show resolved Hide resolved
@shumkov shumkov changed the title feat(dapi): Rust DAPI client feat(dapi): rust DAPI client Jul 20, 2023
@shumkov shumkov changed the title feat(dapi): rust DAPI client feat(dapi): rust client Jul 20, 2023
shumkov
shumkov previously requested changes Jul 21, 2023
View reviewed changes
packages/rs-dapi-client/src/settings.rs Outdated Show resolved Hide resolved
packages/rs-dapi-client/src/lib.rs Outdated Show resolved Hide resolved
packages/rs-dapi-client/src/lib.rs Outdated Show resolved Hide resolved
packages/rs-dapi-client/src/platform/broadcast_state_transition.rs Outdated Show resolved Hide resolved
packages/rs-dapi-client/src/platform/broadcast_state_transition.rs Outdated Show resolved Hide resolved
lklimek
lklimek requested changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@lklimek lklimek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Who is the intended audience? External users or our team?
  2. Please add tests.
  3. Please document public objects, preferably with examples (esp. if audience is external)

packages/rs-dapi-client/src/platform/get_documents.rs Outdated Show resolved Hide resolved
packages/rs-dapi-client/src/platform/get_documents.rs Outdated Show resolved Hide resolved
packages/rs-dapi-client/src/platform/get_identity.rs Outdated Show resolved Hide resolved
@fominok
Copy link
Contributor Author

fominok commented Jul 21, 2023 •
edited
Loading

@lklimek

  1. Who is the intended audience? External users or our team?

I don't know, I suppose both

  1. Please add tests.

The crate does actually nothing but a proxifying requests and I guess only end to end would help there, should it be a Docker thing again?

  1. Please document public objects, preferably with examples (esp. if audience is external)

it has #[deny(missing_docs)], not sure what else to document. A usage example is provided in the crate root. If you're referring to docs that are TODO it's because I genuinely don't know what it is to document it

fominok added 13 commits July 25, 2023 17:00
@fominok
remove wrapper types for dapi client
752bcfc
@fominok
Merge remote-tracking branch 'origin/feat/rs-drive-light-client' into…
4155e37 
… rs-dapi-client
@fominok
mark retryable tonic statuses
83d86b4
@fominok
option to use self-signed certificates
99ded5e
@fominok
Merge remote-tracking branch 'origin/feat/rs-drive-light-client' into…
bb65537 
… rs-dapi-client
@fominok
Merge remote-tracking branch 'origin/feat/rs-drive-light-client' into…
c4c5eeb 
… rs-dapi-client
@fominok
Merge remote-tracking branch 'origin/feat/rs-drive-light-client' into…
2fd3ab9 
… rs-dapi-client
@fominok
Revert "proto typed document query"
b38449d 
This reverts commit 8afbd04.
@fominok
revert proto changes
f50c15a
@fominok
allow http if Uri says so
5e6605b
@fominok
remove insecure option till the better times
04fda53
@fominok
optional integration test for dapi client on local platform
2a30fd5
@fominok
Merge remote-tracking branch 'origin/feat/rs-drive-light-client' into…
0a8a89e 
… rs-dapi-client
@fominok fominok requested review from lklimek and shumkov August 23, 2023 15:49
lklimek
lklimek reviewed Aug 25, 2023
View reviewed changes
Copy link
Contributor

@lklimek lklimek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this :) Will try to use it for my needs, meanwhile I left a few small comments.

packages/rs-dapi-client/src/transport/json_rpc.rs Outdated Show resolved Hide resolved
packages/rs-dapi-client/tests/local_platform_connectivity.rs Show resolved Hide resolved
packages/rs-sdk/src/core.rs Outdated Show resolved Hide resolved
packages/rs-dapi-client/tests/local_platform_connectivity.rs Show resolved Hide resolved
lklimek
lklimek reviewed Aug 25, 2023
View reviewed changes
Cargo.toml Show resolved Hide resolved
@fominok fominok dismissed shumkov’s stale review August 29, 2023 09:57

the thing was mostly rewritten

@fominok fominok merged commit 957e0a5 into feat/rs-drive-light-client Aug 29, 2023
@fominok fominok deleted the rs-dapi-client branch August 29, 2023 09:58
This was referenced Oct 4, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lklimek lklimek lklimek approved these changes

@antouhou antouhou Awaiting requested review from antouhou

@QuantumExplorer QuantumExplorer Awaiting requested review from QuantumExplorer

@shumkov shumkov Awaiting requested review from shumkov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fominok @shumkov @lklimek