chore: merge master back into develop #6571

PastaPastaPasta · 2025-02-11T14:02:19Z

Issue being fixed or feature implemented

Manually suppressed configure.ac changes

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

Go over all the following points, and put an x in all the boxes that apply.

I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have added or updated relevant unit/integration/functional/e2e tests
I have made corresponding changes to the documentation
I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

c11ec40 docs: add release notes for 22.1.0 (pasta) Pull request description: ## Issue being fixed or feature implemented Release notes for 22.1 ## What was done? ## How Has This Been Tested? ## Breaking Changes ## Checklist: _Go over all the following points, and put an `x` in all the boxes that apply._ - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ Top commit has no ACKs. Tree-SHA512: de0fbf02c916a1013e24c6b5aa433068c7cfa6a9e390800f48f9148447794c960034e24411621c98d51702f9e1e907e51ece5985811d40a170791d207c95c67a

aa6593a chore: bump assume valid / checkpoints for v22.1 (pasta) Pull request description: ## Issue being fixed or feature implemented Bump assume valid / checkpoint for upcoming 22.1 release ## What was done? ## How Has This Been Tested? ## Breaking Changes ## Checklist: - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: kwvg: utACK aa6593a UdjinM6: utACK aa6593a Tree-SHA512: 99755f527b94a1be4ead3dd3a5171c6f00c77b1807e005e64a813cce9e5299c507cf47115cfd07a11f86f15f6c9e1247c3d3635bb1c9e69d4930a363499f98f8

ff785ed docs: update man pages for 22.1 (Konstantin Akimov) Pull request description: ## Issue being fixed or feature implemented dashpay#6551 ## What was done? Updated man pages by new script `contrib/devtools/gen-manpages.py` see dashpay#6555 ## How Has This Been Tested? N/A ## Breaking Changes N/A ## Checklist: - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: PastaPastaPasta: utACK ff785ed; diff looks good UdjinM6: utACK ff785ed Tree-SHA512: 60a81c880e6ff824fc661dc6c6da20d85aa662fe228f7080dcb8c47db69c88adc30a40ab84832d83994ab56a26ed1de4d800dd45cd282c61233fde2d4e2212b7

f8811df docs: update supported versions in SECURITY.md (Kittywhiskers Van Gogh) Pull request description: ## Additional Information Updates the supported versions list in `SECURITY.md` ## Checklist: - [x] I have performed a self-review of my own code **(note: N/A)** - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)** - [x] I have added or updated relevant unit/integration/functional/e2e tests **(note: N/A)** - [x] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: UdjinM6: utACK f8811df Tree-SHA512: 3b10dd8ea49ea63d94b9a7df0cc95f5ae0d8fe8a6e8455d09478082bb397f63025953f2786e021730a4951763295c882b9b26a61ca691fccc44072c12da52072

…ges, rewrite in Python 69b1328 Merge bitcoin#24263: doc: Fix gen-manpages, rewrite in Python (fanquake) Pull request description: ## Issue being fixed or feature implemented gen-pages.sh doesn't work correctly for `dash-cli`, it removes all hyphens somehow: ```diff .IP Set a whitelist to filter incoming RPC calls for a specific user. The field <whitelist> comes in the format: <USERNAME>:<rpc 1>,<rpc 2>,...,<rpc n>. If multiple whitelists are set for a given user, -they are set\-intersected. See \fB\-rpcwhitelistdefault\fR documentation +they are setintersected. See \fBrpcwhitelistdefault\fR documentation for information on default whitelist behavior. .HP ``` ## What was done? - backport bitcoin#24263 Rewrite the manual page generation script in Python. This: - solves '-' stripping issue (fixes bitcoin#22681) - makes that a copyright footer is generated correctly again Also change the release process to swap gen-manpages and update RC steps, so that the pages will have the correct rc and/or final version. ## How Has This Been Tested? Produced correct documents for Dash Core v22.1: dashpay#6554 ## Breaking Changes N/A ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: PastaPastaPasta: utACK 69b1328; looks correct UdjinM6: utACK 69b1328 kwvg: utACK 69b1328 Tree-SHA512: 01a7a9a8a4ba762e6ff36035a3fb554d998232d62da8c3441b12741e6a3b626c01c581c1ff3f6aa3dcac02e15d62eec7f2a7f94be9399895557cd0a7115424a7

e62b4eb Merge dashpay#6555: backport: Merge bitcoin#24263: doc: Fix gen-manpages, rewrite in Python (pasta) 53d0ff1 Merge dashpay#6552: docs: update supported versions in SECURITY.md (pasta) 4571d89 Merge dashpay#6554: docs: update man pages for 22.1 (pasta) bc91a83 Merge dashpay#6553: chore: bump assume valid / checkpoints for v22.1 (pasta) Pull request description: ## Issue being fixed or feature implemented Backports from develop to 22.1 ## What was done? ## How Has This Been Tested? ## Breaking Changes ## Checklist: _Go over all the following points, and put an `x` in all the boxes that apply._ - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: UdjinM6: utACK e62b4eb Tree-SHA512: 9f88c1a77ec1adc453b023b764f91760e13064c86d109c29bb7856f2588c6450e518c9479f8c3e245f7eeaf5ef6d28aa85f00b4b5e94ef5a4d80cb5b3d7fdff2

774a018 chore: set release to true (pasta) Pull request description: ## Issue being fixed or feature implemented Final PR before tagging, set release to true ## What was done? ## How Has This Been Tested? ## Breaking Changes ## Checklist: _Go over all the following points, and put an `x` in all the boxes that apply._ - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: UdjinM6: utACK 774a018 (to merge after dashpay#6556) Tree-SHA512: 09bc855dc9917ae84430df3acb1e8f36f280b65bd0c25b0a28c4c996933c560abb94d1c88c11f22db264e64119e5a6ba5e49a8e046b3b8c9ee0c1832641d402c

Manually suppressed configure.ac changes

coderabbitai · 2025-02-11T14:05:02Z

Walkthrough

The changes span multiple release notes documents for Dash Core and include updates to command line arguments, RPC methods, packaging formats, and GUI behavior. The modifications remove outdated testing parameters, replacing them with a new argument, and adjust several RPC endpoints by adding new ones, updating existing ones, or deprecating legacy fee fields. Additionally, the macOS distribution packaging has been shifted from DMG to ZIP archives. The persistent locking of UTXOs via both RPC and GUI has been introduced or clarified. Overall, the release version has been updated from v22.0.0 to v22.1.0, with accompanying alterations in command line options and protocol enhancements that affect P2P communication.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (3)

doc/release-notes.md (2)

1-4: Verify release type classification.

The release is marked as "optional" but introduces significant changes like enabling BIP324/v2 P2P protocol by default. Consider clarifying the impact on network participants who choose not to upgrade.

🧰 Tools

🪛 LanguageTool

[style] ~3-~3: This is not the usual sequence for adjectives that have no special emphasis.
Context: # Dash Core version v22.1.0 This is a new minor version release, bringing new features,...

(EN_ADJ_ORDER)

67-74: Consider adding deprecation timeline for fee fields.

While the deprecation notice for fee fields is clear, consider adding a specific version number or timeline for their removal.

doc/release-notes/dash/release-notes-22.0.0.md (1)

193-196: Update deprecation notice.

The document mentions -platform-user will be removed in version 23.x. Consider adding a reference to this in v22.1.0 release notes to maintain continuity of deprecation notices.

🧰 Tools

🪛 markdownlint-cli2 (0.17.2)

194-194: Unordered list indentation
Expected: 2; Actual: 4

(MD007, ul-indent)

195-195: Unordered list indentation
Expected: 2; Actual: 4

(MD007, ul-indent)

196-196: Unordered list indentation
Expected: 2; Actual: 4

(MD007, ul-indent)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c76e134 and fd51512.

📒 Files selected for processing (7)

doc/release-notes-6325.md (0 hunks)
doc/release-notes-6455.md (0 hunks)
doc/release-notes-6499.md (0 hunks)
doc/release-notes-6516.md (0 hunks)
doc/release-notes-6530.md (0 hunks)
doc/release-notes.md (4 hunks)
doc/release-notes/dash/release-notes-22.0.0.md (1 hunks)

💤 Files with no reviewable changes (5)

doc/release-notes-6516.md
doc/release-notes-6325.md
doc/release-notes-6499.md
doc/release-notes-6530.md
doc/release-notes-6455.md

🧰 Additional context used

🪛 LanguageTool

doc/release-notes/dash/release-notes-22.0.0.md

[grammar] ~70-~70: The word “opt-in” is a noun. The verb is spelled with a space.
Context: ... - Enable Encryption: Users can opt-in to use BIP324 by adding v2transport=1...

(NOUN_VERB_CONFUSION)

[style] ~77-~77: ‘Future Plans’ might be wordy. Consider a shorter alternative.
Context: ...nencrypted channels. - Status and Future Plans - Experimental Phase: Thi...

(EN_WORDINESS_PREMIUM_FUTURE_PLANS)

[uncategorized] ~96-~96: Loose punctuation mark.
Context: ...n a wallet. - coinjoinsalt get: Fetches an existing salt. - `co...