fix: Fix missing includes #5295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UdjinM6
requested changes
Apr 5, 2023
OlegGirko
force-pushed
the
fix_missing_includes
branch
from
212d235 to
9d01937
Compare
The <stdexcept> include is needed for std::runtime_error definition. The <cstdint> include is needed for uint8_t and uint32_t definition. Signed-off-by: Oleg Girko <[email protected]>
OlegGirko
force-pushed
the
fix_missing_includes
branch
from
9d01937 to
89f9c28
Compare
|
Rebased on updated |
PastaPastaPasta
approved these changes
Apr 6, 2023
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Apr 6, 2023
The `<stdexcept>` include is needed for `std::runtime_error` definition. The `<cstdint>` include is needed for `uint8_t` and `uint32_t` definition. ## Issue being fixed or feature implemented Compilation failure with GCC 13. GCC 13 is more strict about missing includes that were included indirectly by previous versions of GCC. ## What was done? Added missing includes. ## How Has This Been Tested? Successful compilation on Fedora 38 with GCC 13. All tests passed successfully. ## Breaking Changes None. ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation Signed-off-by: Oleg Girko <[email protected]> Co-authored-by: Oleg Girko <[email protected]>
PastaPastaPasta
pushed a commit
that referenced
this pull request
May 26, 2023
…acktraces (#5375) ## Description Pull request was inspired by the need to debug lock problems when working on #5352. As far as I'm aware, only macOS has `-Werror=thread-safety` as part of its default `CXXFLAGS` despite the capability being present on Linux as well. This PR introduces thread safety checks for that into our thread sanitizer build. Additionally, since we're using Clang, something that on first glimpse, appears to be something that `stacktraces.cpp` isn't happy with, due to `-Wl,-wrap` being available only on GCC, that no longer seems to be the case, since the version of Clang with comes with `focal`, its `lld` _does_ have support for `-wrap` (see [man page for `lld` on `focal`](https://manpages.ubuntu.com/manpages/focal/en/man1/lld.1.html)). The current `stable` version of Clang/LLVM is 15, at the time of this pull request (see https://apt.llvm.org/) but `focal` ships with an older version, requiring us to use the official LLVM APT repository. I feel we should be testing with recent compilers alongside the ones shipped by LTS distributions. Certain bugs are only made apparent when testing on rolling release distros or distros that have faster update cycles, like Fedora (see #5295 for an illustration of that), which ship with more recent compilers. Until we overhaul our CI systems to test using those distros directly (our current infrastructure is centered around using a "development image" with an LTS distro as the base), this is the best we can do. A similar pull request testing against the latest GCC stable will be welcome as that is currently outside the scope of this PR as the changes made were to make sure that builds were operating as expected on Clang/LLVM 15. --------- Co-authored-by: UdjinM6 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
<stdexcept>include is needed forstd::runtime_errordefinition.The
<cstdint>include is needed foruint8_tanduint32_tdefinition.Issue being fixed or feature implemented
Compilation failure with GCC 13.
GCC 13 is more strict about missing includes that were included indirectly by previous versions of GCC.
What was done?
Added missing includes.
How Has This Been Tested?
Successful compilation on Fedora 38 with GCC 13. All tests passed successfully.
Breaking Changes
None.
Checklist: