Implement dynamic activation thresholds #3692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thephez
reviewed
Sep 8, 2020
UdjinM6
force-pushed
the
dynthresholds
branch
from
c688e0c to
8f676f8
Compare
xdustinface
suggested changes
Sep 10, 2020
UdjinM6
force-pushed
the
dynthresholds
branch
2 times, most recently
from
77bd404 to
dae4a19
Compare
UdjinM6
force-pushed
the
dynthresholds
branch
from
dae4a19 to
60ae186
Compare
|
ACK, Looks good to me 👍 |
xdustinface
approved these changes
Sep 11, 2020
PastaPastaPasta
approved these changes
Sep 12, 2020
| @@ -74,7 +74,7 @@ def signal(self, num_blocks, expected_lockin): | |||
| assert_equal(get_bip9_status(self.nodes[0], 'realloc')['status'], 'started') | |||
|
|
|||
| def threshold(self, attempt): | |||
| threshold_calc = 400 - attempt * attempt; | |||
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Sep 12, 2020
* Implement dynamic activation thresholds * fix * Revert unrelated changes * Clarify switching to/staying in LOCKED_IN state * Fix signal function to work correctly with num_blocks=0 * Add simplified threshold calculation and use it in tests * Check that thresholds are decreasing, reach the min level and stay there * Drop `;`
gades
pushed a commit
to cosanta/cosanta-core
that referenced
this pull request
Mar 11, 2022
* Implement dynamic activation thresholds * fix * Revert unrelated changes * Clarify switching to/staying in LOCKED_IN state * Fix signal function to work correctly with num_blocks=0 * Add simplified threshold calculation and use it in tests * Check that thresholds are decreasing, reach the min level and stay there * Drop `;`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements dynamic BIP9-like activation threshold and applies it to Block Reward Reallocation proposal.
Motivation: in Dash we used to use lower thresholds (80% vs 95% in BTC) to activate upgrades via BIP9-like mechanism for quite some time. While it's preferable to have as much of the network hashrate to signal update readiness as possible this can result in quite lengthy upgrades sometimes when one large non-upgraded entity would stale the whole progress. Simply lowering thresholds even further can result in network upgrades being too fast which can cause some chaos potentially. This PR implements dynamic thresholds which drop from some initial level to a minimally acceptable level over time at an increasing rate.
For regtest params it looks like this:
(based on #3691 atm)