Fix (dead)locks #1169
Merged
Fix (dead)locks #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should fix this: ``` Assertion failed: lock governance.cs not held in governance-classes.cpp:117; locks held: cs_Shutdown init.cpp:200 (TRY) cs ./governance.h:195 cs governance.cpp:835 Abort trap: 6 ```
This was referenced Dec 2, 2016
Merged
codablock
added a commit
to codablock/dash
that referenced
this pull request
Dec 22, 2017
Fix was introdeced in: dashpay#1169 A fix was later applied to fix a race condition: dashpay#1178 This has to be reverted to be able to backport multiple changes from Bitcoin. Later backported PRs from Bitcoin will remove cs_mapRelay and thus also remove the deadlock that was initially fixed with the above PRs.
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
Fix was introdeced in: dashpay#1169 A fix was later applied to fix a race condition: dashpay#1178 This has to be reverted to be able to backport multiple changes from Bitcoin. Later backported PRs from Bitcoin will remove cs_mapRelay and thus also remove the deadlock that was initially fixed with the above PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaner/reworked version of #1168 (changes are grouped into individual commits now, some changes were dropped).