Skip to content
This repository has been archived by the owner on Jul 12, 2022. It is now read-only.

fix: wrong assetlock tx fee estimation #85

Merged
merged 1 commit into from
Jun 16, 2020
Merged

fix: wrong assetlock tx fee estimation #85

merged 1 commit into from
Jun 16, 2020

Conversation

antouhou
Copy link
Contributor

Issue being fixed or feature implemented

Error with 'min relay fee not met' when registering/topping up an identity

What was done?

Remove fee estimation from createAssetLockTransaction and fallback on the default estimation algorithm

How Has This Been Tested?

Run existing tests

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

@shumkov shumkov changed the title fix: Hotfix for the assetlock tx fee estimation fix: wrong assetlock tx fee estimation Jun 16, 2020
shumkov
shumkov approved these changes Jun 16, 2020
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 👍

@shumkov shumkov merged commit 39ba8f1 into master Jun 16, 2020
@shumkov shumkov deleted the fix-fundintx-fee branch June 16, 2020 10:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@shumkov shumkov shumkov approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antouhou @shumkov