Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regroup utility functions in HTMLAudioElement.__CPU__ ? or directly in HTMLAudioElement.prototype ? #143

Closed
dascritch opened this issue Apr 10, 2021 · 2 comments
Closed

regroup utility functions in HTMLAudioElement.__CPU__ ? or directly in HTMLAudioElement.prototype ? #143

dascritch opened this issue Apr 10, 2021 · 2 comments
Labels
question Further information is requested

Comments

@dascritch
Copy link
Owner

dascritch commented Apr 10, 2021 •
edited
Loading

Need advice first. A lot of small functions in media_element_extensions.js can go in the HTMLAudioElement
@dascritch dascritch changed the title regroup pure audiotag function in audiotag.__CPU__ ? regroup utility functions in HTMLAudioElement.__CPU__ ? or directly in HTMLAudioElement ? Apr 10, 2021
@dascritch dascritch changed the title regroup utility functions in HTMLAudioElement.__CPU__ ? or directly in HTMLAudioElement ? regroup utility functions in HTMLAudioElement.__CPU__ ? or directly in HTMLAudioElement.prototype ? Apr 10, 2021
@dascritch dascritch added the question Further information is requested label Apr 15, 2021
@dascritch
Copy link
Owner Author

Won't be done if no arguments before 7.0 release. Elsewhere, programmed for 8.0 release

@dascritch
Copy link
Owner Author

dascritch commented Apr 17, 2021 •
edited
Loading

Still existing methods added on the prototype of HTMLAudioElement are now removed. We can close.
Sorry, forgot to reference my commits. Here they are :

I'm really sorry for my friends I asked to have a look on this issue, finally I didn't sleep this night ^^;

dascritch added a commit that referenced this issue Apr 17, 2021
@dascritch
About removed HTMLAudioElement.CPU_Update() and `HTMLAudioElement.C…
118fb88 
…PU_Controller()`

regroup utility functions in HTMLAudioElement.__CPU__ ? or directly in HTMLAudioElement.prototype ? #143

I should go to sleep now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dascritch