Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring with ECMA classes #115

Closed
dascritch opened this issue Mar 16, 2021 · 4 comments
Closed

Refactoring with ECMA classes #115

dascritch opened this issue Mar 16, 2021 · 4 comments
Assignees
@dascritch
Labels
standards first

Comments

@dascritch
Copy link
Owner

thanks @tdd for your lights
@dascritch dascritch self-assigned this Mar 16, 2021
@dascritch
Copy link
Owner Author

dascritch commented Mar 16, 2021 •
edited
Loading

using setters for defaults_ instead of get_*

@dascritch
Copy link
Owner Author

using destructured data object.

@dascritch
Copy link
Owner Author

named parameter default values.
okokokok

dascritch added a commit that referenced this issue Mar 16, 2021
@dascritch
using getters and spreads in default_dataset
5ca50e6 
Refactoring with ECMA classes #115
dascritch added a commit that referenced this issue Mar 16, 2021
@dascritch
|| and spreads
dc4d84f 
Refactoring with ECMA classes #115
@dascritch
Copy link
Owner Author

But alas, now, puppeter hangs.

dascritch added a commit that referenced this issue Mar 16, 2021
@dascritch
refactoring and noting for tests
0fc7735 
Refactoring with ECMA classes #115
dascritch added a commit that referenced this issue Mar 16, 2021
@dascritch
Chrome headless doesn't support ||=
c414d6c 
Refactoring with ECMA classes #115
dascritch added a commit that referenced this issue Mar 16, 2021
@dascritch
Sugarize
a4282ef 
Refactoring with ECMA classes #115
dascritch added a commit that referenced this issue Mar 16, 2021
@dascritch
Code simplification
270bcb5 
Refactoring with ECMA classes #115
dascritch added a commit that referenced this issue Mar 16, 2021
@dascritch
try to remove some consts from methods
e5e4e90 
Refactoring with ECMA classes #115
dascritch added a commit that referenced this issue Mar 16, 2021
@dascritch
Refacto
942cdd6 
Refactoring with ECMA classes #115
dascritch added a commit that referenced this issue Mar 16, 2021
@dascritch
Destructuring
8d6a919 
Refactoring with ECMA classes #115
dascritch added a commit that referenced this issue Mar 16, 2021
@dascritch
How I didn't see it sooner ?
7e9b320 
Refactoring with ECMA classes #115
dascritch added a commit that referenced this issue Mar 17, 2021
@dascritch
Destructuring arrays
560e161 
Refactoring with ECMA classes #115
dascritch added a commit that referenced this issue Mar 17, 2021
@dascritch
Refacto
e4181fe 
Refactoring with ECMA classes #115
dascritch added a commit that referenced this issue Mar 17, 2021
@dascritch
Elvis not dead
474ff23 
Refactoring with ECMA classes #115
dascritch added a commit that referenced this issue Mar 18, 2021
@dascritch
Isolate default parameters from document_cpu.js
6bcd63d 
Refactoring with ECMA classes #115
dascritch added a commit that referenced this issue Mar 18, 2021
@dascritch
default_dataset only exposed for document_cpu.js for tests
1d1c49f 
Refactoring with ECMA classes #115
dascritch added a commit that referenced this issue Mar 18, 2021
@dascritch
Convertiing finger_manager
42ee8ab 
Refactoring with ECMA classes #115
dascritch added a commit that referenced this issue Mar 19, 2021
@dascritch
Splitting press manager
7c8615c 
Refactoring with ECMA classes #115
dascritch added a commit that referenced this issue Mar 19, 2021
@dascritch
remove unneccessary convert. object and refactoring #elapse
c8e9d97 
Refactoring with ECMA classes #115
dascritch added a commit that referenced this issue Mar 22, 2021
@dascritch
regroup is_audiotag_streamed() and really privatize add_id_to_audiotag()
22945de 
Refactoring with ECMA classes #115
dascritch added a commit that referenced this issue Mar 22, 2021
@dascritch
Removing private methods from public class
6f016c8 
Refactoring with ECMA classes #115
dascritch added a commit that referenced this issue Mar 22, 2021
@dascritch
build_chapters and build_playlist are now strictly private
ec22c6c 
Refactoring with ECMA classes #115
dascritch added a commit that referenced this issue Mar 22, 2021
@dascritch
Remove private find_interface and find_container from document.CPU
3029b68 
Refactoring with ECMA classes #115
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dascritch dascritch

Labels
standards first
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dascritch