-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove multi-file DartPad usages from cheatsheet #5392
Conversation
Visit the preview URL for this PR (updated for commit 449e0c5): https://dart-dev--pr5392-cheatsheet-crrjrj27.web.app (expires Fri, 29 Dec 2023 00:14:03 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d851bc446d3c4d7394c5406c6f07255afc7075f3 |
Thanks for raising your concerns. I think we can still figure out something useful here. Do you have time to meet for 30 minutes today (12/5)? Might be easier to discuss our options synchronously. |
@parlough I was already planning to leave the new section on
In that light, going over |
I think it's fine to move to a follow-up CL, but I'd say it does fit the theme of being a unique (and cool) feature to Dart. Python and JS don't have a I'd also be happy to write it out if you think it's valuable. Just let me know! |
Oh perfect, didn't know that and that info will help me write the section too. Created #5414 , thanks!
If you'd prefer getting it into this PR, then by all means feel free to add it! But otherwise I'm happy to handle it too! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great @MaryaBelanger!! Thanks so much for taking this on, especially unplanned and on a short notice.
I was worried how it would turn out without all of the original DartPad functionality, but it's not too different and I think the core benefits of the page still remain.
I left a few suggestions and questions, but nothing blocking.
A few sample tests do need still need to be updated to move away from _result
, but I'd be happy to do that (and any of the other comments) as follow-up if you have other things you have to/prefer to work on right now. Just let me know :)
@parlough Thanks for the thorough review. I went through and there were a lot of Edit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much, looks great!
Part of dart-lang#5382 - The tests feature contained `main` for each example, but that features being removed. The examples need `main` to run, and also are not helpful without the feedback that the tests provided, so we're adding the tests to code visible in each dartpad. - Comment at the top of each that this part is tests, don't edit - Will have to adjust the tests for more useful messages to users. - Since `main` is a big focus now, add a new section on the `main` function at the top of the cheatsheet. - Also remove hint and solution feature and place in expandable "solution" section under each example. - Rewrite the intro section to explain the new way the page works. --------- Co-authored-by: Parker Lougheed <[email protected]>
Part of #5382
The tests feature contained
main
for each example, but that features being removed. The examples needmain
to run, and also are not helpful without the feedback that the tests provided, so we're adding the tests to code visible in each dartpad.main
is a big focus now, add a new section on themain
function at the top of the cheatsheet.Also remove hint and solution feature and place in expandable "solution" section under each example.
Rewrite the intro section to explain the new way the page works.