Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flutter customer tests reference strong-mode #50751

Closed
6 tasks
srawlins opened this issue Dec 15, 2022 · 1 comment
Closed
6 tasks

Flutter customer tests reference strong-mode #50751

srawlins opened this issue Dec 15, 2022 · 1 comment
Assignees
@srawlins
Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P1 A high priority bug; for example, a single project is unusable or has many test failures type-task A well-defined stand-alone task

Comments

@srawlins
Copy link
Member

srawlins commented Dec 15, 2022 •
edited
Loading

We're removing the strong-mode analysis option, so we must clean up these customer tests. At least a subset of the failures are represented here: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8794686073636648161/+/u/Customer_testing/customer_testing/test_stdout

For each repo, if I understand correctly, I must land a fix in the repo, then change the SHA which is referenced in the tests:
@srawlins srawlins added P1 A high priority bug; for example, a single project is unusable or has many test failures type-task A well-defined stand-alone task area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. labels Dec 15, 2022
@srawlins srawlins mentioned this issue Dec 15, 2022
Merged
@srawlins srawlins self-assigned this Dec 16, 2022
@incendial incendial mentioned this issue Dec 16, 2022
Merged
8 tasks
srawlins added a commit to flutter/tests that referenced this issue Dec 19, 2022
@srawlins
Bump the DanTup_tiler commit
10e99d6 
See commit here: DanTup/tiler@5703643

Work towards dart-lang/sdk#50751
@srawlins srawlins mentioned this issue Dec 19, 2022
Merged
8 tasks
srawlins added a commit to flutter/tests that referenced this issue Dec 19, 2022
@srawlins
Bump flutter_cocoon test commit
220398e 
Bump to this commit flutter/cocoon@fe43094
which contains fixes for Dart 3.

Work towards dart-lang/sdk#50751
@srawlins srawlins mentioned this issue Dec 19, 2022
Merged
8 tasks
srawlins added a commit to flutter/tests that referenced this issue Dec 19, 2022
@srawlins
Bump commit for flutter_portal test
2b3078f 
This bumps flutter_portal to include
fzyzcjy/flutter_portal#97
which contains fixes necessary for Dart 3.

Work towards dart-lang/sdk#50751
@srawlins srawlins mentioned this issue Dec 19, 2022
Merged
8 tasks
srawlins added a commit to flutter/tests that referenced this issue Dec 19, 2022
@srawlins
Bump the commit for provider.test
4ece4aa 
This commit includes rrousselGit/provider#794 which is a necessary change for Dart 3.

Work towards dart-lang/sdk#50751
@srawlins srawlins mentioned this issue Dec 19, 2022
Merged
8 tasks
srawlins added a commit to flutter/tests that referenced this issue Dec 19, 2022
@srawlins
Bump the commit for flutter_svg.test
eaa72b7 
This commit contains dnfield/flutter_svg#818 which is necessary for Dart 3.

Work towards dart-lang/sdk#50751
@srawlins srawlins mentioned this issue Dec 19, 2022
Merged
8 tasks
srawlins added a commit to flutter/tests that referenced this issue Dec 19, 2022
@srawlins
Bump the commit for flutter_gallery.test
6cb0fa3 
This commit includes flutter/gallery#844 which is required for Dart 3.

Work towards dart-lang/sdk#50751
@srawlins srawlins mentioned this issue Dec 19, 2022
Merged
8 tasks
goderbauer pushed a commit to flutter/tests that referenced this issue Jan 4, 2023
@srawlins
Bump the commit for provider.test (#196)
35098ed 
This commit includes rrousselGit/provider#794 which is a necessary change for Dart 3.

Work towards dart-lang/sdk#50751
goderbauer pushed a commit to flutter/tests that referenced this issue Jan 4, 2023
@srawlins
Bump the commit for flutter_svg.test (#197)
0a321e5 
This commit contains dnfield/flutter_svg#818 which is necessary for Dart 3.

Work towards dart-lang/sdk#50751
srawlins added a commit to flutter/tests that referenced this issue Jan 4, 2023
@srawlins
Bump the DanTup_tiler commit (#193)
10e60d4 
See commit here: DanTup/tiler@5703643

Work towards dart-lang/sdk#50751
srawlins added a commit to flutter/tests that referenced this issue Jan 4, 2023
@srawlins
Bump the commit for flutter_gallery.test (#198)
c91cd5f 
This commit includes flutter/gallery#844 which is required for Dart 3.

Work towards dart-lang/sdk#50751
srawlins added a commit to flutter/tests that referenced this issue Jan 4, 2023
@srawlins
Bump flutter_cocoon test commit (#194)
adb859d 
Bump to this commit flutter/cocoon@fe43094
which contains fixes for Dart 3.

Work towards dart-lang/sdk#50751
srawlins added a commit to flutter/tests that referenced this issue Jan 4, 2023
@srawlins
Bump commit for flutter_portal test (#195)
f025c10 
This bumps flutter_portal to include
fzyzcjy/flutter_portal#97
which contains fixes necessary for Dart 3.

Work towards dart-lang/sdk#50751
@srawlins
Copy link
Member Author

srawlins commented Jan 9, 2023

All merged!

@srawlins srawlins closed this as completed Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srawlins srawlins

Labels
area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. P1 A high priority bug; for example, a single project is unusable or has many test failures type-task A well-defined stand-alone task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@srawlins