Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyzer defines bogus feature descriptions #40860

Closed
stereotype441 opened this issue Mar 3, 2020 · 1 comment
Closed

Analyzer defines bogus feature descriptions #40860

stereotype441 opened this issue Mar 3, 2020 · 1 comment
Assignees
Labels
analyzer-technical-debt area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.

Comments

@stereotype441
Copy link
Member

stereotype441 commented Mar 3, 2020

The file pkg/analyzer/lib/src/dart/analysis/experiments.g.dart defines two non-existent language features: bogus-disabled, a non-existent feature that is in the "disabled" state, and bogus-enabled, a non-existent feature that is in the "enabled" state.

These bogus features were not intended to be kept around in the long term; they were created solely to illustrate the file format while it was being developed. However, at least one client (dartdoc) has begun to rely on them, so it is a breaking change to remove them. (Issue to make dartdoc stop using these bogus features is here: dart-lang/dartdoc#2156)

We should remove these "features" so that they don't become a source of confusion to clients.

@stereotype441 stereotype441 added area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion. analyzer-technical-debt labels Mar 3, 2020
@scheglov scheglov self-assigned this Jun 28, 2020
dart-bot pushed a commit that referenced this issue Jul 7, 2020
So, that we unblock #40860

Bug: dart-lang/dartdoc#2156
Change-Id: I0e4df8527b2868863de42d631c0833bd38fb448c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153420
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Devon Carew <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>
@scheglov
Copy link
Contributor

scheglov commented Jul 9, 2020

dart-bot pushed a commit that referenced this issue Jul 9, 2020
[email protected], [email protected]

Bug: #40860
Change-Id: I9ce962b43cc9d0d865a54d0b31a30245e5f7c001
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153707
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
@scheglov scheglov closed this as completed Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analyzer-technical-debt area-analyzer Use area-analyzer for Dart analyzer issues, including the analysis server and code completion.
Projects
None yet
Development

No branches or pull requests

2 participants