Skip to content
This repository has been archived by the owner on Nov 20, 2024. It is now read-only.

Leave backup text crumbs pointing to new docs #4582

Merged

Conversation

parlough
Copy link
Member

@parlough parlough commented Jul 20, 2023

This PR will regenerate each page with textual directions pointing and linking to the new documentation. It should likely never be seen due to the redirects created in #4504, however it acts as a backup in case a client doesn't support those for some reason. It also removes unnecessary doc generation code that is no longer used after these changes.

After this lands and the pages on gh-pages are updated, this generation logic can be (mostly) removed.

Contributes to dart-lang/sdk#59186

@coveralls
Copy link

Coverage Status

coverage: 96.731%. remained the same when pulling a25e670 on parlough:misc/leave-text-crumbs-pointing-to-new-docs into cb926fa on dart-lang:main.

@bwilkerson bwilkerson requested a review from pq July 20, 2023 14:35
Copy link
Member

@pq pq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💎

@pq
Copy link
Member

pq commented Jul 20, 2023

@parlough: is this ready to land?

@parlough
Copy link
Member Author

@pq Yep, this should be good to land!

@pq pq merged commit 9a070d2 into dart-lang:main Jul 20, 2023
@parlough parlough deleted the misc/leave-text-crumbs-pointing-to-new-docs branch July 20, 2023 16:54
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Aug 23, 2023
* Leave backup text crumbs pointing to new docs

* Revert addition of unreachable_from_main
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants