Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update validate-sdk-docs task to allow 20 libs #3404

Merged
merged 1 commit into from
May 3, 2023
Merged

Update validate-sdk-docs task to allow 20 libs #3404

merged 1 commit into from
May 3, 2023

Conversation

srawlins
Copy link
Member

@srawlins srawlins commented May 2, 2023

No description provided.

@srawlins srawlins requested a review from jcollins-g May 2, 2023 21:26
jcollins-g
jcollins-g reviewed May 3, 2023
View reviewed changes
Copy link
Contributor

@jcollins-g jcollins-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we support an SDK that has 18 libraries anymore, so that can be dropped, optionally.

@srawlins
Copy link
Member Author

srawlins commented May 3, 2023

I thought so too; I thought "well, it's probably 18 on old SDKs and 19 on newish" but I didn't want to investigate 🤣

@srawlins srawlins merged commit 60055b4 into dart-lang:main May 3, 2023
@srawlins srawlins deleted the twenty-sdk-libs branch May 3, 2023 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcollins-g jcollins-g jcollins-g approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srawlins @jcollins-g