This repository was archived by the owner on Jul 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 267
feat: add prefer-define-hero-tag rule #1184
Merged
incendial
merged 5 commits into
dart-code-checker:master
from
san-smith:prefer-define-hero-tag
Mar 17, 2023
Merged
feat: add prefer-define-hero-tag rule #1184
incendial
merged 5 commits into
dart-code-checker:master
from
san-smith:prefer-define-hero-tag
Mar 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1184 +/- ##
==========================================
+ Coverage 86.21% 86.26% +0.04%
==========================================
Files 359 361 +2
Lines 8133 8160 +27
==========================================
+ Hits 7012 7039 +27
Misses 1121 1121
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
612a90e
to
adc21d6
Compare
adc21d6
to
be6a8f5
Compare
incendial
reviewed
Feb 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Left a few comments though.
lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_define_hero_tag/visitor.dart
Show resolved
Hide resolved
.../lint_analyzer/rules/rules_list/prefer_define_hero_tag/prefer_define_hero_tag_rule_test.dart
Outdated
Show resolved
Hide resolved
test/src/analyzers/lint_analyzer/rules/rules_list/prefer_define_hero_tag/examples/example.dart
Show resolved
Hide resolved
lib/src/analyzers/lint_analyzer/rules/rules_list/prefer_define_hero_tag/visitor.dart
Outdated
Show resolved
Hide resolved
incendial
approved these changes
Feb 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1027
Please write a short comment explaining your change (or "none" for internal only changes)
Added new rule
prefer-define-hero-tag
.Rule documentation
Good example
Bad example