fix: support assert(mounted) for use-setstate-synchronously

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## Unreleased
+
+* fix: support `assert(mounted)` for [`use-setstate-synchronously`](https://dcm.dev/docs/individuals/rules/flutter/use-setstate-synchronously).
+
 ## 5.6.0-dev.1
 
 * docs: remove old website

lib/src/analyzers/lint_analyzer/rules/rules_list/use_setstate_synchronously/visitor.dart

@@ -43,6 +43,13 @@ class _AsyncSetStateVisitor extends RecursiveAstVisitor<void> {
     super.visitAwaitExpression(node);
   }
 
+  @override
+  void visitAssertStatement(AssertStatement node) {
+    final newMounted = _extractMountedCheck(node.condition);
+    mounted = newMounted.or(mounted);
+    super.visitAssertStatement(node);
+  }
+
   @override
   void visitMethodInvocation(MethodInvocation node) {
     if (!inAsync) {
@@ -65,7 +72,6 @@ class _AsyncSetStateVisitor extends RecursiveAstVisitor<void> {
       return node.visitChildren(this);
     }
 
-    node.condition.visitChildren(this);
     final newMounted = _extractMountedCheck(node.condition);
     mounted = newMounted.or(mounted);
 
@@ -153,9 +159,8 @@ class _AsyncSetStateVisitor extends RecursiveAstVisitor<void> {
     final oldMounted = mounted;
     node.body.visitChildren(this);
     final afterBody = mounted;
-    // ignore: omit_local_variable_types
-    final MountedFact beforeCatch =
-        mounted == oldMounted ? oldMounted : false.asFact();
+    final beforeCatch =
+        mounted == oldMounted ? oldMounted : false.asFact<BinaryExpression>();
     for (final clause in node.catchClauses) {
       mounted = beforeCatch;
       clause.visitChildren(this);

test/src/analyzers/lint_analyzer/rules/rules_list/use_setstate_synchronously/examples/assert_example.dart

@@ -0,0 +1,43 @@
+class _FooState extends State<StatefulWidget> {
+  Widget build(context) {
+    return FooWidget(
+      onChange: (value) async {
+        setState(() {});
+        await fetchData();
+        setState(() {}); // LINT
+
+        assert(mounted);
+        setState(() {});
+      },
+    );
+  }
+
+  void pathologicalCases() async {
+    setState(() {});
+
+    await fetch();
+    this.setState(() {}); // LINT
+
+    if (1 == 1) {
+      setState(() {}); // LINT
+    } else {
+      assert(mounted);
+      setState(() {});
+      return;
+    }
+    setState(() {}); // LINT
+
+    await fetch();
+    if (mounted && foo) {
+      assert(mounted);
+    } else {
+      return;
+    }
+    setState(() {}); // LINT
+
+    assert(mounted);
+    setState(() {});
+  }
+}
+
+class State {}

test/src/analyzers/lint_analyzer/rules/rules_list/use_setstate_synchronously/use_setstate_synchronously_rule_test.dart

@@ -10,6 +10,8 @@ const _trySwitchPath =
     'use_setstate_synchronously/examples/extras_try_switch.dart';
 const _contextMountedPath =
     'use_setstate_synchronously/examples/context_mounted.dart';
+const _assertExample =
+    'use_setstate_synchronously/examples/assert_example.dart';
 
 void main() {
   group('UseSetStateSynchronouslyTest', () {
@@ -118,6 +120,31 @@ void main() {
       );
     });
 
+    test('reports issues with assert statements', () async {
+      final unit = await RuleTestHelper.resolveFromFile(_assertExample);
+      final issues = UseSetStateSynchronouslyRule().check(unit);
+
+      RuleTestHelper.verifyIssues(
+        issues: issues,
+        startLines: [7, 19, 22, 28, 36],
+        startColumns: [9, 10, 7, 5, 5],
+        locationTexts: [
+          'setState',
+          'setState',
+          'setState',
+          'setState',
+          'setState',
+        ],
+        messages: [
+          "Avoid calling 'setState' past an await point without checking if the widget is mounted.",
+          "Avoid calling 'setState' past an await point without checking if the widget is mounted.",
+          "Avoid calling 'setState' past an await point without checking if the widget is mounted.",
+          "Avoid calling 'setState' past an await point without checking if the widget is mounted.",
+          "Avoid calling 'setState' past an await point without checking if the widget is mounted.",
+        ],
+      );
+    });
+
     test('reports no issues for context.mounted', () async {
       final unit = await RuleTestHelper.resolveFromFile(_contextMountedPath);
       final issues = UseSetStateSynchronouslyRule().check(unit);