Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

feat: support context.mounted for use-setstate-synchronously #1164

Merged
merged 2 commits into from
Jan 28, 2023

Conversation

incendial
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

@incendial incendial added this to the 5.5.0 milestone Jan 27, 2023
@incendial incendial requested a review from dkrutskikh January 27, 2023 12:33
@incendial incendial self-assigned this Jan 27, 2023
@incendial
Copy link
Member Author

@Desdaemon hey, could you please take a look too?

@Desdaemon
Copy link
Contributor

LGTM (?)

@incendial
Copy link
Member Author

(?)

@Desdaemon thank you, but I'm not sure what this means 😅

@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

Merging #1164 (2ecd43e) into master (ae2674f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1164   +/-   ##
=======================================
  Coverage   85.59%   85.59%           
=======================================
  Files         350      350           
  Lines        7926     7928    +2     
=======================================
+ Hits         6784     6786    +2     
  Misses       1142     1142           
Impacted Files Coverage Δ
...rules_list/use_setstate_synchronously/helpers.dart 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@incendial incendial merged commit d20764e into master Jan 28, 2023
@incendial incendial deleted the support-context-mounted branch January 28, 2023 11:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants