Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

feat: add new rule correct-game-instantiating #1163

Merged
merged 3 commits into from
Jan 29, 2023

Conversation

incendial
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

@incendial incendial added type: enhancement New feature or request area-rules labels Jan 27, 2023
@incendial incendial added this to the 5.6.0 milestone Jan 27, 2023
@incendial incendial requested a review from dkrutskikh January 27, 2023 08:43
@incendial incendial self-assigned this Jan 27, 2023
@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #1163 (8075573) into master (8676f24) will increase coverage by 0.05%.
The diff coverage is 98.14%.

❗ Current head 8075573 differs from pull request most recent head 50cf829. Consider uploading reports for the commit 50cf829 to get more accurate results

@@            Coverage Diff             @@
##           master    #1163      +/-   ##
==========================================
+ Coverage   85.62%   85.67%   +0.05%     
==========================================
  Files         350      353       +3     
  Lines        7944     7980      +36     
==========================================
+ Hits         6802     6837      +35     
- Misses       1142     1143       +1     
Impacted Files Coverage Δ
...nalyzers/lint_analyzer/rules/models/rule_type.dart 100.00% <ø> (ø)
...c/analyzers/lint_analyzer/rules/rules_factory.dart 75.00% <ø> (ø)
...instantiating/correct_game_instantiating_rule.dart 95.83% <95.83%> (ø)
...alyzers/lint_analyzer/rules/models/flame_rule.dart 100.00% <100.00%> (ø)
...rules_list/correct_game_instantiating/visitor.dart 100.00% <100.00%> (ø)
lib/src/utils/flutter_types_utils.dart 100.00% <100.00%> (ø)
...les_list/no_magic_number/no_magic_number_rule.dart 93.47% <0.00%> (-1.53%) ⬇️
...ules/rules_list/no_magic_number/config_parser.dart 100.00% <0.00%> (ø)
...rules_list/use_setstate_synchronously/helpers.dart 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@spydon
Copy link

spydon commented Jan 27, 2023

Looks good! 🔥

import 'rule.dart';
import 'rule_type.dart';

/// Represents a base class for Flutter-specific rules.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@incendial maybe for Flutter Flame Engine ?

@dkrutskikh dkrutskikh merged commit c3a124a into master Jan 29, 2023
@dkrutskikh dkrutskikh deleted the add-correct-game-instantiating branch January 29, 2023 17:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-rules type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants