Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

fix: partially handle normal completion function body for avoid-redundant-async #1148

Merged
merged 4 commits into from
Jan 20, 2023

Conversation

incendial
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

#1147

@incendial incendial added this to the 5.5.0 milestone Jan 11, 2023
@incendial incendial requested a review from dkrutskikh January 11, 2023 08:43
@incendial incendial self-assigned this Jan 11, 2023
@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #1148 (48229a1) into master (7f9e642) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 48229a1 differs from pull request most recent head d49d7a4. Consider uploading reports for the commit d49d7a4 to get more accurate results

@@            Coverage Diff             @@
##           master    #1148      +/-   ##
==========================================
+ Coverage   85.53%   85.56%   +0.02%     
==========================================
  Files         350      350              
  Lines        7897     7909      +12     
==========================================
+ Hits         6755     6767      +12     
  Misses       1142     1142              
Impacted Files Coverage Δ
...ules/rules_list/avoid_redundant_async/visitor.dart 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@incendial incendial marked this pull request as draft January 13, 2023 20:18
@incendial incendial marked this pull request as ready for review January 15, 2023 16:55
@incendial incendial merged commit 7ce686f into master Jan 20, 2023
@incendial incendial deleted the avoid-redundant-async-normal-completion branch January 20, 2023 12:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant