Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

feat: show warning for rules without config that require config to work #1125

Merged
merged 2 commits into from
Dec 28, 2022

Conversation

incendial
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

@incendial incendial added type: enhancement New feature or request area-rules labels Dec 26, 2022
@incendial incendial added this to the 5.4.0 milestone Dec 26, 2022
@incendial incendial requested a review from dkrutskikh December 26, 2022 13:07
@incendial incendial self-assigned this Dec 26, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

github-actions bot commented Dec 26, 2022

Dart Code Metrics unused files report of dart_code_metrics. ✅

Summary

  • Scanned package folders: bin, example, lib
  • No unused files found! ✅

@github-actions
Copy link

github-actions bot commented Dec 26, 2022

Dart Code Metrics analyze report of dart_code_metrics. ✅

Summary

  • Scanned folders: bin, example, lib, test

  • Total scanned files: 548

  • Total lines of source code: 9790

  • Total classes: 419

  • Average Cyclomatic Number per line of code: 0.37 / 2

  • Average Source Lines of Code per method: 6

  • Total tech debt: 2072.0 hours

  • Found issues: 5 ⚠

@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Merging #1125 (89c4faa) into master (a352607) will decrease coverage by 0.05%.
The diff coverage is 61.29%.

@@            Coverage Diff             @@
##           master    #1125      +/-   ##
==========================================
- Coverage   85.19%   85.14%   -0.06%     
==========================================
  Files         342      342              
  Lines        7540     7559      +19     
==========================================
+ Hits         6424     6436      +12     
- Misses       1116     1123       +7     
Impacted Files Coverage Δ
...void_banned_imports/avoid_banned_imports_rule.dart 81.81% <0.00%> (-3.90%) ⬇️
...lyzer/rules/rules_list/ban_name/ban_name_rule.dart 85.18% <0.00%> (-3.28%) ⬇️
...lint_analyzer/lint_analysis_options_validator.dart 58.73% <64.28%> (+3.41%) ⬆️
...src/analyzers/lint_analyzer/rules/models/rule.dart 33.33% <100.00%> (+13.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@incendial incendial merged commit 2bb60d4 into master Dec 28, 2022
@incendial incendial deleted the improve-rules-config-validation branch December 28, 2022 07:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-rules type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant