fix: correctly handle prefixed enums and static instance fields for prefer-moving-to-variable

[incendial]

What is the purpose of this pull request? (put an "X" next to an item)

• Documentation update
• Bug fix
• New rule
• Changes an existing rule
• Add autofixing to a rule
• Add a CLI option
• Add something to the core
• Other, please explain:

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[github-actions]

Dart Code Metrics unused files report of dart_code_metrics. ✅

Summary

• Scanned package folders: bin, example, lib
• No unused files found! ✅

[github-actions]

Dart Code Metrics analyze report of dart_code_metrics. ✅

Summary

• Scanned folders: bin, example, lib, test

• Total scanned files: 541

• Total lines of source code: 9567

• Total classes: 409

• Average Cyclomatic Number per line of code: 0.37 / 2

• Average Source Lines of Code per method: 6

• Total tech debt: 2040.0 hours

• Found issues: 5 ⚠

[codecov]

Codecov Report

Merging #1123 (d9fbf65) into master (29e6181) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1123   +/-   ##
=======================================
  Coverage   85.54%   85.54%           
=======================================
  Files         349      349           
  Lines        7870     7873    +3     
=======================================
+ Hits         6732     6735    +3     
  Misses       1138     1138           

Impacted Files	Coverage Δ
...ng_to_variable/prefer_moving_to_variable_rule.dart	81.25% <ø> (ø)
.../rules_list/prefer_moving_to_variable/visitor.dart	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[jacob314]

try referencing prefix.SomeValue.firstValue
repeatedly
I believe that would match the case where I was seeing false positives.

[incendial]

Yes, that's it! Thank you!

[incendial]

Hm, actually, if I duplicate the line 5 AnotherEnum.anotherValue; the rule will also trigger. So it's not connected to prefixes, maybe you remember other cases?

[jacob314]

The strange thing is removing the prefixes did seem to fix the issue in DevTools. That said, I wouldn't want the rule to trigger for duplicated AnotherEnum.anotherValue case either. Specifying the enum value name twice seems more idiomatic than defining an unneeded local variable.

[incendial]

Agree. And maybe the same should work for the class level static variables. You probably wouldn't want to assign this type of calls to a variable.

[jacob314]

Agree that I wouldn't want this firing for class to class level static variables either.

[incendial]

Sorry for misleading, it was a problem exactly with the prefixes 🤦
Now fixed, thank you!

[jacob314]