Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

feat: support ignoring nesting for prefer-conditional-expressions #1122

Merged
merged 2 commits into from
Dec 28, 2022

Conversation

incendial
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

@incendial incendial added type: enhancement New feature or request area-rules labels Dec 26, 2022
@incendial incendial added this to the 5.4.0 milestone Dec 26, 2022
@incendial incendial requested a review from dkrutskikh December 26, 2022 11:04
@incendial incendial self-assigned this Dec 26, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

github-actions bot commented Dec 26, 2022

Dart Code Metrics unused files report of dart_code_metrics. ✅

Summary

  • Scanned package folders: bin, example, lib
  • No unused files found! ✅

@github-actions
Copy link

github-actions bot commented Dec 26, 2022

Dart Code Metrics analyze report of dart_code_metrics. ✅

Summary

  • Scanned folders: bin, example, lib, test

  • Total scanned files: 548

  • Total lines of source code: 9758

  • Total classes: 419

  • Average Cyclomatic Number per line of code: 0.37 / 2

  • Average Source Lines of Code per method: 6

  • Total tech debt: 2072.0 hours

  • Found issues: 5 ⚠

@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Merging #1122 (5b1724e) into master (a352607) will decrease coverage by 0.01%.
The diff coverage is 88.46%.

@@            Coverage Diff             @@
##           master    #1122      +/-   ##
==========================================
- Coverage   85.19%   85.18%   -0.02%     
==========================================
  Files         342      343       +1     
  Lines        7540     7554      +14     
==========================================
+ Hits         6424     6435      +11     
- Misses       1116     1119       +3     
Impacted Files Coverage Δ
...pressions/prefer_conditional_expressions_rule.dart 93.75% <50.00%> (-6.25%) ⬇️
.../prefer_conditional_expressions/config_parser.dart 100.00% <100.00%> (ø)
...s_list/prefer_conditional_expressions/visitor.dart 100.00% <100.00%> (ø)
.../rules_list/prefer_static_class/config_parser.dart 100.00% <100.00%> (ø)
.../prefer_static_class/prefer_static_class_rule.dart 78.26% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@incendial incendial merged commit 8feb0e9 into master Dec 28, 2022
@incendial incendial deleted the nesting-config-prefer-conditional-expressions branch December 28, 2022 07:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-rules type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant