Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

feat: add strict config option to avoid-collection-methods-with-unrelated-types #1111

Merged

Conversation

incendial
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

#1108

@incendial incendial added type: enhancement New feature or request area-rules labels Dec 16, 2022
@incendial incendial added this to the 5.3.0 milestone Dec 16, 2022
@incendial incendial requested a review from dkrutskikh December 16, 2022 14:29
@incendial incendial self-assigned this Dec 16, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

github-actions bot commented Dec 16, 2022

Dart Code Metrics unused files report of dart_code_metrics. ✅

Summary

  • Scanned package folders: bin, example, lib
  • No unused files found! ✅

@github-actions
Copy link

github-actions bot commented Dec 16, 2022

Dart Code Metrics analyze report of dart_code_metrics. ✅

Summary

  • Scanned folders: bin, example, lib, test

  • Total scanned files: 538

  • Total lines of source code: 9487

  • Total classes: 405

  • Average Cyclomatic Number per line of code: 0.37 / 2

  • Average Source Lines of Code per method: 6

  • Total tech debt: 2000.0 hours

  • Found issues: 5 ⚠

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #1111 (7024c66) into master (b8f190c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 7024c66 differs from pull request most recent head 80714e4. Consider uploading reports for the commit 80714e4 to get more accurate results

@@            Coverage Diff             @@
##           master    #1111      +/-   ##
==========================================
+ Coverage   85.02%   85.04%   +0.01%     
==========================================
  Files         339      340       +1     
  Lines        7445     7454       +9     
==========================================
+ Hits         6330     6339       +9     
  Misses       1115     1115              
Impacted Files Coverage Δ
..._collection_methods_with_unrelated_types_rule.dart 100.00% <100.00%> (ø)
...on_methods_with_unrelated_types/config_parser.dart 100.00% <100.00%> (ø)
...llection_methods_with_unrelated_types/visitor.dart 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@incendial incendial merged commit 2dd4c83 into master Dec 16, 2022
@incendial incendial deleted the strict-avoid-collection-methods-with-unrelated-types branch December 16, 2022 15:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-rules type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant