Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

feat: add list-all-equatable-fields rule #1103

Merged
merged 11 commits into from
Dec 19, 2022
Merged

Conversation

incendial
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

Not adding docs for now, waiting for the rule behaviour to be approved.

@incendial incendial added type: enhancement New feature or request area-rules labels Dec 14, 2022
@incendial incendial added this to the 5.3.0 milestone Dec 14, 2022
@incendial incendial requested a review from dkrutskikh December 14, 2022 14:38
@incendial incendial self-assigned this Dec 14, 2022
@xsahil03x
Copy link
Contributor

@incendial you missed EquatableMixin

@incendial
Copy link
Member Author

@xsahil03x yeah, I know. I'll add support for it later if the current implementation works as expected. If you have other ideas for equatable rules - please let me know!

@github-actions
Copy link

github-actions bot commented Dec 14, 2022

Dart Code Metrics unused files report of dart_code_metrics. ✅

Summary

  • Scanned package folders: bin, example, lib
  • No unused files found! ✅

@github-actions
Copy link

github-actions bot commented Dec 14, 2022

Dart Code Metrics analyze report of dart_code_metrics. ✅

Summary

  • Scanned folders: bin, example, lib, test

  • Total scanned files: 541

  • Total lines of source code: 9567

  • Total classes: 409

  • Average Cyclomatic Number per line of code: 0.37 / 2

  • Average Source Lines of Code per method: 6

  • Total tech debt: 2040.0 hours

  • Found issues: 5 ⚠

@codecov
Copy link

codecov bot commented Dec 19, 2022

Codecov Report

Merging #1103 (eea4673) into master (2dd4c83) will increase coverage by 0.14%.
The diff coverage is 100.00%.

❗ Current head eea4673 differs from pull request most recent head 7d43270. Consider uploading reports for the commit 7d43270 to get more accurate results

@@            Coverage Diff             @@
##           master    #1103      +/-   ##
==========================================
+ Coverage   85.05%   85.19%   +0.14%     
==========================================
  Files         340      342       +2     
  Lines        7468     7539      +71     
==========================================
+ Hits         6352     6423      +71     
  Misses       1116     1116              
Impacted Files Coverage Δ
...c/analyzers/lint_analyzer/rules/rules_factory.dart 75.00% <ø> (ø)
...uatable_fields/list_all_equatable_fields_rule.dart 100.00% <100.00%> (ø)
.../rules_list/list_all_equatable_fields/visitor.dart 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@incendial
Copy link
Member Author

@xsahil03x I've added support for mixins.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@incendial incendial merged commit 8eae6f6 into master Dec 19, 2022
@incendial incendial deleted the list-all-equatable-fields branch December 19, 2022 15:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-rules type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants