Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

fix: correctly support conditional imports for check-unused-code #1097

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

incendial
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

#1083

@incendial incendial added this to the 5.2.0 milestone Dec 8, 2022
@incendial incendial requested a review from dkrutskikh December 8, 2022 13:27
@incendial incendial self-assigned this Dec 8, 2022
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

Dart Code Metrics unused files report of dart_code_metrics. ✅

Summary

  • Scanned package folders: bin, example, lib
  • No unused files found! ✅

@github-actions
Copy link

github-actions bot commented Dec 8, 2022

Dart Code Metrics analyze report of dart_code_metrics. ✅

Summary

  • Scanned folders: bin, example, lib, test

  • Total scanned files: 537

  • Total lines of source code: 9466

  • Total classes: 404

  • Average Cyclomatic Number per line of code: 0.37 / 2

  • Average Source Lines of Code per method: 6

  • Total tech debt: 1976.0 hours

  • Found issues: 5 ⚠

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #1097 (3ce82ce) into master (9b1efee) will decrease coverage by 0.06%.
The diff coverage is 91.89%.

@@            Coverage Diff             @@
##           master    #1097      +/-   ##
==========================================
- Coverage   85.09%   85.02%   -0.07%     
==========================================
  Files         339      339              
  Lines        7418     7445      +27     
==========================================
+ Hits         6312     6330      +18     
- Misses       1106     1115       +9     
Impacted Files Coverage Δ
...ers/unused_code_analyzer/unused_code_analyzer.dart 93.13% <87.50%> (-3.74%) ⬇️
...lyzers/unused_code_analyzer/used_code_visitor.dart 75.65% <95.00%> (+1.96%) ⬆️
...used_code_analyzer/models/file_elements_usage.dart 100.00% <100.00%> (ø)
...sed_code_analyzer/models/prefix_element_usage.dart 33.33% <0.00%> (-66.67%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@incendial incendial merged commit f395fd5 into master Dec 8, 2022
@incendial incendial deleted the check-unused-code-conditional-imports branch December 8, 2022 14:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant