Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

feat: add avoid-unnecessary-conditionals rule #1094

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

incendial
Copy link
Member

What is the purpose of this pull request? (put an "X" next to an item)

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

Addresses https://github.com/dart-lang/linter/issues/3888 and flutter/devtools#4890

@incendial incendial added type: enhancement New feature or request area-rules labels Dec 8, 2022
@incendial incendial added this to the 5.2.0 milestone Dec 8, 2022
@incendial incendial requested a review from dkrutskikh December 8, 2022 09:21
@incendial incendial self-assigned this Dec 8, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link

github-actions bot commented Dec 8, 2022

Dart Code Metrics unused files report of dart_code_metrics. ✅

Summary

  • Scanned package folders: bin, example, lib
  • No unused files found! ✅

@github-actions
Copy link

github-actions bot commented Dec 8, 2022

Dart Code Metrics analyze report of dart_code_metrics. ✅

Summary

  • Scanned folders: bin, example, lib, test

  • Total scanned files: 532

  • Total lines of source code: 9396

  • Total classes: 402

  • Average Cyclomatic Number per line of code: 0.37 / 2

  • Average Source Lines of Code per method: 6

  • Total tech debt: 1952.0 hours

  • Found issues: 5 ⚠

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #1094 (1ef030a) into master (7db92de) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    dart-lang/linter#1094      +/-   ##
==========================================
+ Coverage   84.97%   85.03%   +0.05%     
==========================================
  Files         335      337       +2     
  Lines        7361     7389      +28     
==========================================
+ Hits         6255     6283      +28     
  Misses       1106     1106              
Impacted Files Coverage Δ
...c/analyzers/lint_analyzer/rules/rules_factory.dart 75.00% <ø> (ø)
...ditionals/avoid_unnecessary_conditionals_rule.dart 100.00% <100.00%> (ø)
...s_list/avoid_unnecessary_conditionals/visitor.dart 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@incendial incendial merged commit 7a96369 into master Dec 8, 2022
@incendial incendial deleted the avoid-unnecessary-conditionals branch December 8, 2022 10:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-rules type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant