Skip to content
This repository was archived by the owner on Jul 16, 2023. It is now read-only.

feat: add static code diagnostic prefer-using-list-view #1088

Merged
merged 2 commits into from
Dec 5, 2022
Merged

feat: add static code diagnostic prefer-using-list-view #1088

merged 2 commits into from
Dec 5, 2022

Conversation

lsaudon
Copy link
Contributor

@lsaudon lsaudon commented Dec 2, 2022

What is the purpose of this pull request? (put an "X" next to an item)

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Add a CLI option
  • Add something to the core
  • Other, please explain:

What changes did you make? (Give an overview)

Add static code diagnostic prefer-using-list-view
I check SingleChildScrollView with child Column with only children parameter.

Is there anything you'd like reviewers to focus on?

Not to my knowledge.

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #1088 (cae8eb9) into master (c4a9ad3) will increase coverage by 0.05%.
The diff coverage is 100.00%.

❗ Current head cae8eb9 differs from pull request most recent head 1795ca1. Consider uploading reports for the commit 1795ca1 to get more accurate results

@@            Coverage Diff             @@
##           master    #1088      +/-   ##
==========================================
+ Coverage   84.89%   84.95%   +0.05%     
==========================================
  Files         333      335       +2     
  Lines        7331     7360      +29     
==========================================
+ Hits         6224     6253      +29     
  Misses       1107     1107              
Impacted Files Coverage Δ
...c/analyzers/lint_analyzer/rules/rules_factory.dart 75.00% <ø> (ø)
...r_using_list_view/prefer_using_list_view_rule.dart 100.00% <100.00%> (ø)
...les/rules_list/prefer_using_list_view/visitor.dart 100.00% <100.00%> (ø)
lib/src/utils/flutter_types_utils.dart 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@incendial incendial self-requested a review December 5, 2022 06:53
@incendial incendial added type: enhancement New feature or request area-rules labels Dec 5, 2022
@incendial incendial added this to the 5.2.0 milestone Dec 5, 2022
Copy link
Member

@incendial incendial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lsaudon thank you, great result! Left several small comments

@incendial
Copy link
Member

@lsaudon thank you!

@incendial incendial merged commit 8039dba into dart-code-checker:master Dec 5, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-rules type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants