This repository was archived by the owner on Jul 16, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 267
feat: add static code diagnostic prefer-using-list-view
#1088
Merged
incendial
merged 2 commits into
dart-code-checker:master
from
lsaudon:prefer-using-list-view
Dec 5, 2022
Merged
feat: add static code diagnostic prefer-using-list-view
#1088
incendial
merged 2 commits into
dart-code-checker:master
from
lsaudon:prefer-using-list-view
Dec 5, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1088 +/- ##
==========================================
+ Coverage 84.89% 84.95% +0.05%
==========================================
Files 333 335 +2
Lines 7331 7360 +29
==========================================
+ Hits 6224 6253 +29
Misses 1107 1107
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
incendial
reviewed
Dec 5, 2022
.../lint_analyzer/rules/rules_list/prefer_using_list_view/prefer_using_list_view_rule_test.dart
Show resolved
Hide resolved
incendial
reviewed
Dec 5, 2022
test/src/analyzers/lint_analyzer/rules/rules_list/prefer_using_list_view/examples/example.dart
Outdated
Show resolved
Hide resolved
incendial
reviewed
Dec 5, 2022
incendial
reviewed
Dec 5, 2022
incendial
reviewed
Dec 5, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lsaudon thank you, great result! Left several small comments
@lsaudon thank you! |
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to an item)
What changes did you make? (Give an overview)
Add static code diagnostic
prefer-using-list-view
I check
SingleChildScrollView
withchild
Column
with onlychildren
parameter.Is there anything you'd like reviewers to focus on?
Not to my knowledge.