feat: add static code diagnostic arguments-ordering

[roman-petrov]

arguments-ordering rule

Enforces named argument order in function and constructor invocations to be the same as corresponding named parameter declaration order.

The rule can be used together with sort_child_properties_last rule by setting child-last: true in rule configuration.

⚙️ Config example

dart_code_metrics:
  ...
  rules:
    ...
    - arguments-ordering:
        child-last: true

Example

❌ Bad:

Person buildPerson({ String name, String surname, String age });
// LINT
final person = buildPerson(age: 42, surname: 'The Pooh', name: 'Winnie');

✅ Good:

Person buildPerson({ String name, String surname, String age });
// LINT
final person = buildPerson(name: 'Winnie', surname: 'The Pooh', age: 42);

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[codecov]

Codecov Report

Merging #1047 (465c0cd) into master (2bce6fb) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1047      +/-   ##
==========================================
+ Coverage   84.74%   84.86%   +0.11%     
==========================================
  Files         327      330       +3     
  Lines        7196     7253      +57     
==========================================
+ Hits         6098     6155      +57     
  Misses       1098     1098              

Impacted Files	Coverage Δ
...c/analyzers/lint_analyzer/rules/rules_factory.dart	75.00% <ø> (ø)
...st/arguments_ordering/arguments_ordering_rule.dart	100.00% <100.00%> (ø)
...s/rules_list/arguments_ordering/config_parser.dart	100.00% <100.00%> (ø)
...r/rules/rules_list/arguments_ordering/visitor.dart	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[roman-petrov]

I finally finished this PR :)

This rule might be a bit hard to adopt for large code bases without CLI "auto-fix". However, I managed to test this rule on our relatively large code base and spent just about half a hour to fix all ~250 issues in VSCode by just monkey clicking "Fix" light bulb in problems panel:)

I didn't found any issues with this rule on our code base, auto fix also worked pretty well. So I assume this implementation should be quite ready to ship.

@dkrutskikh , @incendial - could you please take a look?

I've got a strange issue with automated checks for this PR and don't have any idea how it can be fixed:

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[incendial]

Looks great 🔥

But I bet someone might want to have a specific order 😁

[roman-petrov]

But I bet someone might want to have a specific order 😁

Sure 😁 But it will be quite easy to implement new sorting options having "core" rule part completed.