This repository was archived by the owner on Jul 16, 2023. It is now read-only.
feat: add method call chains support on ban-name ident #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added tests - Changed docs
|
Kudos, SonarCloud Quality Gate passed!
|
incendial
reviewed
Oct 14, 2022
lib/src/analyzers/lint_analyzer/rules/rules_list/ban_name/ban_name_rule.dart
Show resolved
Hide resolved
incendial
suggested changes
Oct 16, 2022
lib/src/analyzers/lint_analyzer/rules/rules_list/ban_name/ban_name_rule.dart
Show resolved
Hide resolved
test/src/analyzers/lint_analyzer/rules/rules_list/ban_name/examples/example.dart
Show resolved
Hide resolved
|
@Hideart I'll merge this as is and fix myself. Thank you for the contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to an item)
What changes did you make? (Give an overview)
This PR extends the ban-name rule abilities to recursive search in method call chains. (ex:
DateTime.noworStrangeClass.someField.subFieldetc.)Ban-name rule's visitor will have a breadcrumb now and will compare breadcrumb node names with the rule ident.
Resolves the #927